From 00fe4f4f18b1ef0bc95274c92db81759764eab93 Mon Sep 17 00:00:00 2001
From: Simon Alibert <alibert.sim@gmail.com>
Date: Mon, 11 Mar 2024 13:09:46 +0100
Subject: [PATCH] Configure wandb entity outside config

---
 README.md                    | 7 +++++++
 lerobot/common/logger.py     | 3 ++-
 lerobot/configs/default.yaml | 2 +-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 551270b5..4cc6280a 100644
--- a/README.md
+++ b/README.md
@@ -24,6 +24,12 @@ mkdir ~/tmp
 export TMPDIR='~/tmp'
 ```
 
+To use [Weights and Biases](https://docs.wandb.ai/quickstart) for experiments tracking, login with
+```
+wandb login
+```
+
+
 
 ## Usage
 
@@ -111,6 +117,7 @@ pre-commit run -a
 **Tests**
 
 Install [git lfs](https://git-lfs.com/) to retrieve test artifacts (if you don't have it already).
+
 On Mac:
 ```
 brew install git-lfs
diff --git a/lerobot/common/logger.py b/lerobot/common/logger.py
index 3d98d726..ec6cc705 100644
--- a/lerobot/common/logger.py
+++ b/lerobot/common/logger.py
@@ -38,7 +38,7 @@ class Logger:
         project = cfg.get("wandb", {}).get("project")
         entity = cfg.get("wandb", {}).get("entity")
         enable_wandb = cfg.get("wandb", {}).get("enable", False)
-        run_offline = not enable_wandb or not project or not entity
+        run_offline = not enable_wandb or not project
         if run_offline:
             logging.info(colored("Logs will be saved locally.", "yellow", attrs=["bold"]))
             self._wandb = None
@@ -63,6 +63,7 @@ class Logger:
                 resume=None,
             )
             print(colored("Logs will be synced with wandb.", "blue", attrs=["bold"]))
+            logging.info(f"Track this run --> {colored(wandb.run.get_url(), 'yellow', attrs=['bold'])}")
             self._wandb = wandb
 
     def save_model(self, policy, identifier):
diff --git a/lerobot/configs/default.yaml b/lerobot/configs/default.yaml
index 4a767dd8..7006655e 100644
--- a/lerobot/configs/default.yaml
+++ b/lerobot/configs/default.yaml
@@ -31,5 +31,5 @@ policy: ???
 wandb:
   enable: true
   project: lerobot
-  entity: rcadene  # insert your own
+  # entity: rcadene  # insert your own
   notes: ""