Remove test skips & fix docstrings

This commit is contained in:
Simon Alibert 2025-03-23 17:04:30 +01:00
parent ff7cfdaf40
commit 0ac026b521
2 changed files with 5 additions and 7 deletions

View File

@ -166,7 +166,7 @@ class MockInstructionPacket(MockFeetechPacket):
"""
Builds a "Write" instruction.
The parameters for Write (Protocol 2.0) are:
The parameters for Write are:
param[0] = start_address L
param[1] = start_address H
param[2] = 1st Byte
@ -174,10 +174,10 @@ class MockInstructionPacket(MockFeetechPacket):
...
param[1+X] = X-th Byte
And 'length' = data_length + 5, where:
And 'length' = data_length + 3, where:
+1 is for instruction byte,
+2 is for the length bytes,
+2 is for the CRC at the end.
+1 is for the length bytes,
+1 is for the checksum at the end.
"""
data = FeetechMotorsBus.split_int_bytes(value, data_length)
params = [start_address, *data]
@ -234,7 +234,7 @@ class MockStatusPacket(MockFeetechPacket):
"""Builds a 'Present_Position' status packet.
Args:
scs_id (int): List of the servos ids
scs_id (int): List of the servos ids.
pos (int | None, optional): Desired 'Present_Position' to be returned in the packet. If None, it
will use a random value in the min_max_range. Defaults to None.
min_max_range (tuple, optional): Min/max range to generate the position values used for when 'pos'

View File

@ -401,7 +401,6 @@ def test_sync_write_by_names(ids, positions, mock_motors, dummy_motors):
assert mock_motors.stubs[stub_name].wait_called()
@pytest.mark.skip("TODO")
@pytest.mark.parametrize(
"data_name, dxl_id, value",
[
@ -424,7 +423,6 @@ def test_write_by_id(data_name, dxl_id, value, mock_motors, dummy_motors):
assert mock_motors.stubs[stub_name].called
@pytest.mark.skip("TODO")
@pytest.mark.parametrize(
"data_name, dxl_id, value",
[