Apply suggestions from code review
Various fixes for #74 Co-authored-by: Remi <re.cadene@gmail.com>
This commit is contained in:
parent
38ef878eed
commit
4057cc6c28
|
@ -11,7 +11,7 @@ body:
|
||||||
id: system-info
|
id: system-info
|
||||||
attributes:
|
attributes:
|
||||||
label: System Info
|
label: System Info
|
||||||
description: Please share your lerobot configuration with us. You can run the command `python -m lerobot.commands.env` and copy-paste its outputs below
|
description: If needed, you can share your lerobot configuration with us by running `python -m lerobot.commands.env` and copy-pasting its outputs below
|
||||||
render: Shell
|
render: Shell
|
||||||
placeholder: lerobot version, OS, python version, numpy version, torch version, and lerobot's configuration
|
placeholder: lerobot version, OS, python version, numpy version, torch version, and lerobot's configuration
|
||||||
validations:
|
validations:
|
||||||
|
@ -22,15 +22,6 @@ body:
|
||||||
attributes:
|
attributes:
|
||||||
label: Information
|
label: Information
|
||||||
description: 'The problem arises when using:'
|
description: 'The problem arises when using:'
|
||||||
options:
|
|
||||||
- label: "The official example scripts"
|
|
||||||
- label: "My own modified scripts"
|
|
||||||
|
|
||||||
- type: checkboxes
|
|
||||||
id: information-tasks
|
|
||||||
attributes:
|
|
||||||
label: Tasks
|
|
||||||
description: "The tasks I am working on are:"
|
|
||||||
options:
|
options:
|
||||||
- label: "One of the scripts in the examples/ folder of LeRobot"
|
- label: "One of the scripts in the examples/ folder of LeRobot"
|
||||||
- label: "My own task or dataset (give details below)"
|
- label: "My own task or dataset (give details below)"
|
||||||
|
@ -42,10 +33,10 @@ body:
|
||||||
attributes:
|
attributes:
|
||||||
label: Reproduction
|
label: Reproduction
|
||||||
description: |
|
description: |
|
||||||
Please provide a code sample that reproduces the problem you ran into. It can be a Colab link or just a code snippet.
|
If needed, provide a simple code sample that reproduces the problem you ran into. It can be a Colab link or just a code snippet.
|
||||||
If you have code snippets, error messages, stack traces please provide them here as well.
|
Sharing error messages or stack traces could be useful as well!
|
||||||
Important! Use code tags to correctly format your code. See https://help.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks#syntax-highlighting
|
Important! Use code tags to correctly format your code. See https://help.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks#syntax-highlighting
|
||||||
Do not use screenshots, as they are hard to read and (more importantly) don't allow others to copy-and-paste your code.
|
Try to avoid screenshots, as they are hard to read and don't allow copy-and-pasting.
|
||||||
|
|
||||||
placeholder: |
|
placeholder: |
|
||||||
Steps to reproduce the behavior:
|
Steps to reproduce the behavior:
|
||||||
|
|
|
@ -4,12 +4,12 @@ Example: Fixes # (issue)
|
||||||
|
|
||||||
|
|
||||||
## Before submitting
|
## Before submitting
|
||||||
- [ ] Did you read the [contributor guideline](https://github.com/huggingface/lerobot/blob/main/CONTRIBUTING.md#submitting-a-pull-request-pr), Pull Request section?
|
- Read the [contributor guideline](https://github.com/huggingface/lerobot/blob/main/CONTRIBUTING.md#submitting-a-pull-request-pr).
|
||||||
- [ ] Please provide a minimal example for the reviewer to checkout & try.
|
- Provide a minimal code example for the reviewer to checkout & try.
|
||||||
- [ ] How did you test your changes?
|
- Explain how you tested your changes.
|
||||||
|
|
||||||
|
|
||||||
## Who can review?
|
## Who can review?
|
||||||
|
|
||||||
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
|
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
|
||||||
members/contributors who may be interested in your PR. Please tag fewer than 3 people.
|
members/contributors who may be interested in your PR. Try to avoid tagging more than 3 people.
|
||||||
|
|
|
@ -6,7 +6,7 @@ others, reaching out and improving the documentations are immensely valuable to
|
||||||
the community.
|
the community.
|
||||||
|
|
||||||
It also helps us if you spread the word: reference the library from blog posts
|
It also helps us if you spread the word: reference the library from blog posts
|
||||||
on the awesome projects it made possible, shout out on Twitter every time it has
|
on the awesome projects it made possible, shout out on Twitter when it has
|
||||||
helped you, or simply ⭐️ the repo to say "thank you".
|
helped you, or simply ⭐️ the repo to say "thank you".
|
||||||
|
|
||||||
Whichever way you choose to contribute, please be mindful to respect our
|
Whichever way you choose to contribute, please be mindful to respect our
|
||||||
|
@ -16,7 +16,7 @@ Whichever way you choose to contribute, please be mindful to respect our
|
||||||
|
|
||||||
Some of the ways you can contribute to 🤗 LeRobot:
|
Some of the ways you can contribute to 🤗 LeRobot:
|
||||||
* Fixing outstanding issues with the existing code.
|
* Fixing outstanding issues with the existing code.
|
||||||
* Implementing new models.
|
* Implementing new models, datasets or simulation environments.
|
||||||
* Contributing to the examples or to the documentation.
|
* Contributing to the examples or to the documentation.
|
||||||
* Submitting issues related to bugs or desired new features.
|
* Submitting issues related to bugs or desired new features.
|
||||||
|
|
||||||
|
@ -57,7 +57,7 @@ A good feature request addresses the following points:
|
||||||
about it!
|
about it!
|
||||||
* Is it something you worked on and think could benefit the community?
|
* Is it something you worked on and think could benefit the community?
|
||||||
Awesome! Tell us what problem it solved for you.
|
Awesome! Tell us what problem it solved for you.
|
||||||
2. Write a *full paragraph* describing the feature.
|
2. Write a *paragraph* describing the feature.
|
||||||
3. Provide a **code snippet** that demonstrates its future use.
|
3. Provide a **code snippet** that demonstrates its future use.
|
||||||
4. In case this is related to a paper, please attach a link.
|
4. In case this is related to a paper, please attach a link.
|
||||||
5. Attach any additional information (drawings, screenshots, etc.) you think may help.
|
5. Attach any additional information (drawings, screenshots, etc.) you think may help.
|
||||||
|
@ -211,7 +211,7 @@ Follow these steps to start contributing:
|
||||||
2. If your pull request addresses an issue, please mention the issue number in
|
2. If your pull request addresses an issue, please mention the issue number in
|
||||||
the pull request description to make sure they are linked (and people
|
the pull request description to make sure they are linked (and people
|
||||||
consulting the issue know you are working on it);
|
consulting the issue know you are working on it);
|
||||||
3. To indicate a work in progress please prefix the title with `[WIP]`, or mark
|
3. To indicate a work in progress please prefix the title with `[WIP]`, or preferably mark
|
||||||
the PR as a draft PR. These are useful to avoid duplicated work, and to differentiate
|
the PR as a draft PR. These are useful to avoid duplicated work, and to differentiate
|
||||||
it from PRs ready to be merged;
|
it from PRs ready to be merged;
|
||||||
4. Make sure existing tests pass;
|
4. Make sure existing tests pass;
|
||||||
|
|
Loading…
Reference in New Issue