From 7a75bb9f61ed3b30457051f8e01f93c198f22679 Mon Sep 17 00:00:00 2001 From: Simon Alibert Date: Mon, 24 Mar 2025 21:13:26 +0100 Subject: [PATCH] Improve errors --- lerobot/common/motors/dynamixel/dynamixel.py | 3 +-- lerobot/common/motors/feetech/feetech.py | 2 +- lerobot/common/motors/motors_bus.py | 6 ++---- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/lerobot/common/motors/dynamixel/dynamixel.py b/lerobot/common/motors/dynamixel/dynamixel.py index 30b33896..affe774b 100644 --- a/lerobot/common/motors/dynamixel/dynamixel.py +++ b/lerobot/common/motors/dynamixel/dynamixel.py @@ -148,8 +148,7 @@ class DynamixelMotorsBus(MotorsBus): if not self._is_comm_success(comm): if raise_on_error: - logger.error(self.packet_handler.getRxPacketError(comm)) - raise ConnectionError + raise ConnectionError(self.packet_handler.getRxPacketError(comm)) return data_list if data_list else None diff --git a/lerobot/common/motors/feetech/feetech.py b/lerobot/common/motors/feetech/feetech.py index 45fcff89..67f56efd 100644 --- a/lerobot/common/motors/feetech/feetech.py +++ b/lerobot/common/motors/feetech/feetech.py @@ -203,7 +203,7 @@ class FeetechMotorsBus(MotorsBus): if not self._is_comm_success(comm): if raise_on_error: - raise ConnectionError + raise ConnectionError(self.packet_handler.getRxPacketError(comm)) return ids_status if ids_status else None diff --git a/lerobot/common/motors/motors_bus.py b/lerobot/common/motors/motors_bus.py index 7946ac44..224726e7 100644 --- a/lerobot/common/motors/motors_bus.py +++ b/lerobot/common/motors/motors_bus.py @@ -451,14 +451,12 @@ class MotorsBus(abc.ABC): if not self._is_comm_success(comm): if raise_on_error: - logger.error(self.packet_handler.getRxPacketError(comm)) - raise ConnectionError + raise ConnectionError(self.packet_handler.getRxPacketError(comm)) else: return if self._is_error(error): if raise_on_error: - logger.error(self.packet_handler.getTxRxResult(comm)) - raise ConnectionError + raise RuntimeError(self.packet_handler.getTxRxResult(comm)) else: return